Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Loaders to Highlights in Recording Tools #3562

Merged
merged 5 commits into from
Aug 29, 2024

Conversation

VitorVieiraZ
Copy link
Contributor

@VitorVieiraZ VitorVieiraZ commented Aug 9, 2024

In MMRecordingTools, MMHighlights are loaded only when they match the layer's geometry, improving performance by eliminating the need to load unnecessary components.

0000001.mov

Partially Resolves #2980

@VitorVieiraZ VitorVieiraZ changed the title WIP - Adding Loaders to Highlights Adding Loaders to Highlights in Recording Tools Aug 16, 2024
@tomasMizera tomasMizera added this to the 2024.4.0 milestone Aug 26, 2024
Copy link
Collaborator

@tomasMizera tomasMizera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few changes, but it seems like we are close to merge :)

app/qml/map/MMRecordingTools.qml Outdated Show resolved Hide resolved
app/qml/map/MMRecordingTools.qml Outdated Show resolved Hide resolved
app/qml/map/MMRecordingTools.qml Outdated Show resolved Hide resolved
@VitorVieiraZ VitorVieiraZ modified the milestone: 2024.4.0 Aug 26, 2024
@VitorVieiraZ VitorVieiraZ force-pushed the enhancement/digitizingIdentificationSpeed branch from 616039a to b6011c1 Compare August 26, 2024 15:42
@VitorVieiraZ VitorVieiraZ force-pushed the enhancement/digitizingIdentificationSpeed branch from b6011c1 to 59c9688 Compare August 26, 2024 17:57
app/qml/map/MMRecordingTools.qml Outdated Show resolved Hide resolved
@tomasMizera tomasMizera merged commit d395fca into master Aug 29, 2024
10 of 12 checks passed
@tomasMizera tomasMizera deleted the enhancement/digitizingIdentificationSpeed branch August 29, 2024 09:18
@alexd0793 alexd0793 added the test-success Label to use for PR testing label Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test-success Label to use for PR testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants